fix(build): fix CA1305 error in SmtpEmailService Release build#22
Closed
Morgana-Claw wants to merge 3 commits intomasterfrom
Closed
fix(build): fix CA1305 error in SmtpEmailService Release build#22Morgana-Claw wants to merge 3 commits intomasterfrom
Morgana-Claw wants to merge 3 commits intomasterfrom
Conversation
- Add SendWelcomeEmailToUserAsync method to IEmailService interface - Implement method in SmtpEmailService and SendGridEmailService with branded HTML template - Inject IEmailService into AuthApplication and call it fire-and-forget after successful registration - Email includes: congratulations message, next steps, ClientManager branding - No PDF attachment (unlike customer welcome email) - Update AuthApplicationTests to include IEmailService mock
…lService CA1305 error in Release mode because int.Parse without IFormatProvider varies by locale. This caused Docker build to fail on Render since Directory.Build.props sets TreatWarningsAsErrors=true for Release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Docker build on Render failed because SmtpEmailService.SendWelcomeEmailToUserAsync used int.Parse(string) without specifying CultureInfo.InvariantCulture.
In Directory.Build.props, TreatWarningsAsErrors is enabled for Release mode in non-test projects. The CA1305 analyzer warning became a build error.
Fix
Added CultureInfo.InvariantCulture to the int.Parse call in SendWelcomeEmailToUserAsync, consistent with how it was already done in SendWelcomeEmailAsync (line 12).
Verification